Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: linter error fixes #579

Merged
merged 1 commit into from
Sep 26, 2023
Merged

style: linter error fixes #579

merged 1 commit into from
Sep 26, 2023

Conversation

bernot-dev
Copy link
Collaborator

A few random linter error fixes.

@bernot-dev bernot-dev self-assigned this Sep 26, 2023
Copy link
Member

@TheSpiritXIII TheSpiritXIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How did you run this? I don't see anything in our Makefile to run this. Do you think you can add a command?

@bernot-dev
Copy link
Collaborator Author

I don't see anything in our Makefile to run this. Do you think you can add a command?

Maybe we should try this: https://github.com/golangci/golangci-lint-action

@bernot-dev bernot-dev merged commit e5697f7 into main Sep 26, 2023
8 checks passed
@bernot-dev bernot-dev deleted the bernot-dev/linter-fixes branch September 26, 2023 21:14
@@ -1,5 +1,3 @@
// Copyright 2022 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the tool mean to remove the copyright?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was probably just me fat fingering the deletion of the line. Good catch. I'll add that back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants