Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mTLS support into the example app #570

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add mTLS support into the example app #570

merged 1 commit into from
Sep 25, 2023

Conversation

TheSpiritXIII
Copy link
Member

Example usage:

go run ./examples/instrumentation/go-synthetic/ --tls-create-self-signed=true
curl -k https://localhost:8080/metrics

This PR builds on top of #569.

@TheSpiritXIII TheSpiritXIII mentioned this pull request Sep 15, 2023
Merged
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-tls branch from f5b8a57 to 569a962 Compare September 19, 2023 19:50
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-tls branch from 569a962 to cc95538 Compare September 20, 2023 12:44
bwplotka
bwplotka requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just error handling is off.

examples/instrumentation/go-synthetic/auth.go Outdated Show resolved Hide resolved
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-tls branch from cc95538 to 08fd62c Compare September 22, 2023 13:20
maxamins
maxamins reviewed Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@maxamins maxamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/instrumentation/go-synthetic/auth.go Outdated Show resolved Hide resolved
examples/instrumentation/go-synthetic/main.go Outdated Show resolved Hide resolved
examples/instrumentation/go-synthetic/main.go Outdated Show resolved Hide resolved
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-tls branch from 08fd62c to 7097d8a Compare September 22, 2023 14:47
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/synthetic-tls branch from 7097d8a to fb15890 Compare September 22, 2023 14:48
maxamins
maxamins approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@maxamins maxamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bwplotka
bwplotka approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit 76fccb2 into main Sep 25, 2023
8 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/synthetic-tls branch October 6, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxamins maxamins maxamins approved these changes

@bwplotka bwplotka bwplotka approved these changes

Assignees

@TheSpiritXIII TheSpiritXIII

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSpiritXIII @bwplotka @maxamins