Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Cloud Support Slackbot rearchitecture for Cloud Run #772

Merged
merged 11 commits into from
Feb 25, 2022
Merged

Google Cloud Support Slackbot rearchitecture for Cloud Run #772

merged 11 commits into from
Feb 25, 2022

Conversation

TheLanceLord
Copy link
Member

Changes to the Google Cloud Support Slackbot tool:

  • google-cloud-support-slackbot.py was broken up into smaller method and function files to make future maintenance easier
  • code modified to be container-friendly. The app now writes cases and tracking information to Firestore instead of the local file system so tracking information isn't lost if the container shuts down or the node has an error
  • README updated with instructions for installing the bot using a Slack manifest file and Cloud Run to ease integration
  • original files moved under the archive/standalone folder

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 19, 2022
@boredabdel boredabdel self-requested a review February 21, 2022 06:57
@boredabdel
Copy link
Member

boredabdel commented Feb 21, 2022 •
edited
Loading

@TheLanceLord Thanks for the PR. It seems like you are missing the Google CLA or maybe you used a different email to push this PR which is not the one used to sign the CLA.

Can you check here please https://cla.developers.google.com/clas

@boredabdel
Copy link
Member

@TheLanceLord any updates ?

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. size/XXL Denotes a PR that changes 1000+ lines. and removed size/XXL Denotes a PR that changes 1000+ lines. size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2022
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. size/XXL Denotes a PR that changes 1000+ lines. and removed size/XXL Denotes a PR that changes 1000+ lines. size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2022
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Feb 23, 2022
@TheLanceLord
Copy link
Member Author

there was an issue with my default author on my local machine, I'm recreating the commit

@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2022
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. size/XXL Denotes a PR that changes 1000+ lines. and removed size/XXL Denotes a PR that changes 1000+ lines. size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2022
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Feb 23, 2022
@TheLanceLord
Refactor and rearchitecture of the Google Cloud Support Slackbot code…
7fd0b87 
…. Makes the code container friendly by integrating it with Firestore
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 23, 2022
@TheLanceLord
Copy link
Member Author

@boredabdel alright, the CLA issue is fixed, thanks for your patience!

boredabdel
boredabdel reviewed Feb 24, 2022
View reviewed changes
Copy link
Member

@boredabdel boredabdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

tools/google-cloud-support-slackbot/Dockerfile Outdated Show resolved Hide resolved
tools/google-cloud-support-slackbot/SupportCase.py Outdated Show resolved Hide resolved
boredabdel
boredabdel approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@boredabdel boredabdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boredabdel boredabdel merged commit 2a35d9b into GoogleCloudPlatform:main Feb 25, 2022
vponnam pushed a commit to vponnam/professional-services that referenced this pull request Jul 26, 2022
@TheLanceLord @boredabdel @vponnam
Google Cloud Support Slackbot rearchitecture for Cloud Run (GoogleClo…
23ae0ed 
…udPlatform#772)

* Update README.md

* Refactor and rearchitecture of the Google Cloud Support Slackbot code. Makes the code container friendly by integrating it with Firestore

* README fix for code blocks

* Final README fixes

* updating .dockerignore

* Updated Dockerfile and changed SupportCase.py to support_case.py

Co-authored-by: Abdel SGHIOUAR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boredabdel boredabdel boredabdel approved these changes

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheLanceLord @boredabdel