Switch sample to telemetrygen #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't currently work for metrics because the lowest rate telemetrygen can export is 1/s. Opened open-telemetry/opentelemetry-collector-contrib#33982 upstream to propose a fix to allow us to slow this down to 1/5s |
|
The duplicate timeseries error seems much better with the changes from open-telemetry/opentelemetry-collector-contrib#33984 |
damemi
force-pushed
the
demo-telemetrygen
branch
from
8d03fbd to
c53cb50
Compare
|
@ridwanmsharif this is ready for review, ptal thanks! |
ridwanmsharif
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use upstream
telemetrygenimage as a lightweight replacement to the full otel demoAs a TODO: we should update our fork of the otel demo to work with this pipeline. So, a user could deploy this pipeline, then deploy our fork of the demo (that doesn't use the demo's built in collector and instead points all the apps to this pipeline). This would give users a richer experience if they want it, but also keep us from having to maintain a copy of the otel-demo manifests here