Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added kfp presubmit v2 test #890

Merged
merged 4 commits into from
Jun 8, 2021
Merged

added kfp presubmit v2 test #890

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ac4f33
added kfp presubmit v2 test
capri-xiyue Jun 4, 2021
67ead47
fixed style
capri-xiyue Jun 4, 2021
c244fcb
fixed nits
capri-xiyue Jun 7, 2021
ce93a3e
renamed test
capri-xiyue Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,17 @@ presubmits:
- image: python:3.7
command:
- ./v2/test/presubmit.sh


- name: kubeflow-pipelines-v2-go-test
cluster: build-kubeflow
decorate: true
run_if_changed: "^v2/.*$"
spec:
containers:
- image: gcr.io/google.com/cloudsdktool/cloud-sdk:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, some go tests depend on a real MLMD server at localhost:8080. I think we need one more container for the MLMD server, but I've never set up a sidecar in prow tests before. We need to debug this.

Another approach can be running this test in a KFP pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need side car or another KFP pipeline if we added kubectl port-fprward in the script kubeflow/pipelines@57ebac9#diff-88dcf2f21baa096c2451b3d3dfbc18ad795f135bc4b260721d259345aebf1b73R35?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, good point! I missed the kubectl port-forward command.
Ideally we should test with an empty MLMD db, because some common code path will only run once, but this is good enough for now.

command:
- ./v2/test/presubmit-v2-go-test.sh

- name: kubeflow-pipelines-manifests
cluster: build-kubeflow
decorate: true
Expand Down