Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add httpRequest test coverage for CouchDB. #660

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Add httpRequest test coverage for CouchDB. #660

merged 2 commits into from
Jun 9, 2022

Conversation

qingling128
Copy link
Contributor

No description provided.

@qingling128 qingling128 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 8, 2022
qingling128
qingling128 commented Jun 8, 2022
View reviewed changes
apps/couchdb.go Outdated Show resolved Hide resolved
@qingling128 qingling128 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 8, 2022
@qingling128 qingling128 mentioned this pull request Jun 9, 2022
Merged
@qingling128 qingling128 changed the title Fix the httpRequest label camel case issue for IIS and CouchDB etc. Add httpRequest test coverage for CouchDB. Jun 9, 2022
@qingling128 qingling128 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 9, 2022
@qingling128
Copy link
Contributor Author

Rebased this after #658 is merged. The delta is just some extra test coverage for CouchDB.

@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 9, 2022
@qingling128
Copy link
Contributor Author

qingling128 commented Jun 9, 2022 •
edited
Loading

CouchDB tests passed.

The failures in Ops Agent integration test (Windows) (https://pantheon.corp.google.com/storage/browser/ops-agents-public-buckets-test-logs/prod/stackdriver_agents/testing/consumer/ops_agent/test/windows/168/20220608-190528/logs) is a known issue with TestHTTPRequestLog that is being fixed by #655 I believe.

All the tests in third party apps integration test (Windows) (https://pantheon.corp.google.com/storage/browser/ops-agents-public-buckets-test-logs/prod/stackdriver_agents/testing/consumer/third_party_apps/test/windows/164/20220608-190413/logs) are failing as well though, due to missing *.goo files. It seems to be intermittent. Investigating it separately in b/235415811. Not a blocker for this PR.

@qingling128 qingling128 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 9, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 9, 2022
@qingling128 qingling128 merged commit b29d1b9 into master Jun 9, 2022
@qingling128 qingling128 deleted the lingshi-camel branch June 9, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvans martijnvans martijnvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingling128 @martijnvans @stackdriver-instrumentation-release