-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fluentbit/processor: Update the parser to reserve data while avoiding duplication of keys #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
force-pushed
the
ridwanmsharif/parse_deduplication
branch
8 times, most recently
from
June 7, 2022 03:59
5332fc2
to
d35d573
Compare
braydonk
reviewed
Jun 7, 2022
qingling128
reviewed
Jun 7, 2022
ridwanmsharif
force-pushed
the
ridwanmsharif/parse_deduplication
branch
5 times, most recently
from
June 7, 2022 20:44
8c28ae5
to
66d3720
Compare
qingling128
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ridwanmsharif
force-pushed
the
ridwanmsharif/parse_deduplication
branch
from
June 8, 2022 04:16
66d3720
to
2cce6fb
Compare
ridwanmsharif
added
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Jun 8, 2022
ridwanmsharif
force-pushed
the
ridwanmsharif/parse_deduplication
branch
from
June 8, 2022 20:15
2cce6fb
to
87fdd5f
Compare
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Jun 8, 2022
ridwanmsharif
added
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Jun 9, 2022
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Jun 9, 2022
…d duplication of keys Signed-off-by: Ridwan Sharif <[email protected]>
Signed-off-by: Ridwan Sharif <[email protected]>
Signed-off-by: Ridwan Sharif <[email protected]>
Signed-off-by: Ridwan Sharif <[email protected]>
ridwanmsharif
force-pushed
the
ridwanmsharif/parse_deduplication
branch
from
June 9, 2022 02:01
87fdd5f
to
83a8adc
Compare
ridwanmsharif
added
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Jun 9, 2022
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Jun 9, 2022
The integration test added in the PR passes on Windows. The only failures are unrelated (and a known issue) and are being addressed in b/235115328. Merging this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/226372668.
This change does the following:
Reserve_data
set to "True"logName
(which will be preserved from the original) and thelabels
which will be merged with the parsed payload. See details below. Then delete the temporary internal field.Logic for merging labels:
See full results for the perf benchmarks here: https://screenshot.googleplex.com/5sZHUPnyjMvDXnz
To make sense of the results use the following legend: file -> file receiver with no parsing file_parse_raw -> file + parser file_parse -> file + parse with some fields that exist before parsing (added using another filter thats why there is some perf impact) file_parse_lua -> file + parse + some existing fields + 2 lua filters to deal with deduplication (using the slowest path: some original fields already present and needs merging)