Testing: Prepare to turn on Rocky Linux 8 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvans
commented
Jun 6, 2022
| @@ -1,11 +1,11 @@ | |||
| set -e | |||
|
|
|||
| source /etc/os-release | |||
| case $VERSION_ID in | |||
| case "${VERSION_ID}" in | |||
There was a problem hiding this comment.
this part of the change is an artifact of me trying something different and then not-quite undoing that attempt. But it's good practice to double quote variables in general.
martijnvans
commented
Jun 6, 2022
| 7) | ||
| sudo yum -y install https://download.postgresql.org/pub/repos/yum/reporpms/EL-7-x86_64/pgdg-redhat-repo-latest.noarch.rpm | ||
| ;; | ||
| 8) | ||
| 8|8.*) |
There was a problem hiding this comment.
rocky linux 8 currently has VERSION_ID 8.6. The 8|8.* form will support centos 8, (which is EOL but anyway), as well as any version starting with 8..
martijnvans
requested review from
a team,
jkschulz and
davidbtucker
and removed request for
a team and
jkschulz
davidbtucker
approved these changes
Jun 6, 2022
|
the windows failure is aan unrelated known issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ops_agent_test.gopasses with no changes needed when run locally.third_party_apps_test.goneeded a few small changes, and with them I got a passing result (though some apps have skips configured for everything except debian-10):