Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetty minimum supported metrics version #643

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

EvanSimpson
Copy link
Contributor

Adds missing field in jetty metadata file.

Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingling128 qingling128 merged commit 487639e into GoogleCloudPlatform:master Jun 23, 2022
@@ -8,6 +8,7 @@ description: |-
integration also collects access and system logs. Access logs are parsed
into a JSON payload focused on request details.
minimum_supported_agent_version:
metrics: 2.17.0
Copy link
Contributor

@sophieyfang sophieyfang Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't manually add this version. It should be taken care by the post ops agent release job. Any reason on adding this before we actually released 2.17.0 today..? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants