Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the broken validation on slice structs #636

Merged
merged 1 commit into from
May 27, 2022
Merged

Fix the broken validation on slice structs #636

merged 1 commit into from
May 27, 2022

Conversation

sophieyfang
Copy link
Contributor

@sophieyfang sophieyfang commented May 27, 2022 •
edited by jkschulz
Loading

Test Evidence:
Key: 'IntegrationMetadata.ExpectedMetrics[5].Labels' Error:Field validation for 'Labels' failed on the 'required' tag

TODO: add validation tests http://b/230789204

@sophieyfang sophieyfang requested a review from qingling128 May 27, 2022 22:08
qingling128
qingling128 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophieyfang sophieyfang merged commit fe57229 into master May 27, 2022
@sophieyfang sophieyfang deleted the sophie-val branch May 27, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophieyfang @qingling128