Turned off data integrity check #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilevy18
force-pushed
the
storage-checksum-off
branch
2 times, most recently
from
48e400a to
373c711
Compare
…e filesystem for FluentBit
avilevy18
force-pushed
the
storage-checksum-off
branch
from
373c711 to
baca244
Compare
avilevy18
requested review from
a team and
igorpeshansky
and removed request for
a team
confgenerator/fluentbit/service.go
Outdated
| @@ -36,8 +36,8 @@ func (s Service) Component() Component { | |||
| // https://docs.fluentbit.io/manual/administration/buffering-and-storage#service-section-configuration | |||
| // storage.path is set by Fluent Bit systemd unit (e.g. /var/lib/google-cloud-ops-agent/fluent-bit/buffers). | |||
| "storage.sync": "normal", | |||
| // Enable the data integrity check when writing and reading data from the filesystem. | |||
| "storage.checksum": "on", | |||
| // Turned off due to empty spaces being considered as corrupted. Most users do not enforce checksum. See:b/233109163 for more info | |||
There was a problem hiding this comment.
How about:
Suggested change
| // Turned off due to empty spaces being considered as corrupted. Most users do not enforce checksum. See:b/233109163 for more info | |
| // Disable data integrity check to avoid spurious corruption errors due to empty spaces. | |
| // Most users do not enforce checksum. |
I don't believe there's a need to mention the bug in the code — git blame can trace it to this PR, which already references it.
There was a problem hiding this comment.
Changed in: adf27bc
There was a problem hiding this comment.
Note: Disable, not Disabled (because it describes what the option does, not what this PR did)…
There was a problem hiding this comment.
Thanks for the feedback.
Changed in: d177711
avilevy18
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned off data integrity check when writing and reading logs from the filesystem for FluentBit
http://b/233109163