Add Jetty logging #573
Merged
Add Jetty logging #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
|
Looks like the integrations tests are failing for Jetty. Lets fix that and then we can merge |
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
ridwanmsharif
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Mrod1598
requested review from
ridwanmsharif
and removed request for
jefferbrecht
ridwanmsharif
approved these changes
May 17, 2022
| - name: jsonPayload.message | ||
| value_regex: '.*oejs\.Server:main: Started Server\@.*\{STARTING\}.*' | ||
| type: string | ||
| description: null |
There was a problem hiding this comment.
All the other descriptions default to '' instead of null. We should do that here too
|
Uggggh have to rebase again and will merge then (feel free to merge if you can) |
added 3 commits
May 17, 2022 11:10
sophieyfang
reviewed
May 18, 2022
| For more information about Jetty, see | ||
| [The Jetty Docs](https://www.eclipse.org/jetty/documentation/jetty-11/operations-guide/index.html). | ||
| minimum_supported_agent_version: | ||
| metrics: 2.9.0 |
There was a problem hiding this comment.
This shouldn't be set up. Our release job will assign the actual release version when we trigger our ops-agent release.
There was a problem hiding this comment.
minimum_supported_agent_version for new integration or existing integration with newly added logging/metrics support doesn't need to be manually set.
Our release job will take care of.
There was a problem hiding this comment.
Got it. Would you like me to make a quick PR to fix it?
edit: Nevermind I see you've already done so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a system log processor and access log receiver.
System Log
Access Log
