metadata: add configuration_options for varnish and add validation #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
force-pushed
the
ridwanmsharif/fix-config-options
branch
2 times, most recently
from
6697ef1 to
3ba5285
Compare
ridwanmsharif
commented
Apr 28, 2022
| @@ -1,5 +1,6 @@ | |||
| short_name: varnish | |||
| long_name: Varnish HTTP Cache | |||
| supported_app_version: ["6.0+", "7.0+"] | |||
There was a problem hiding this comment.
@JonathanWamsley Could you confirm that this is the correct supported version for Varnish?
sophieyfang
reviewed
Apr 28, 2022
Comment on lines
383
to
388
| // Validate the metadata. | ||
| validate := validator.New() | ||
| if err = validate.Struct(metadata); err != nil { | ||
| return nonRetryable, err | ||
| } | ||
|
|
There was a problem hiding this comment.
I am also working on this :) It needs to do quite much to get it work in the we intended it to be.😮💨
metadata parsed by unmarshallstrict will allocate any substruct as {} instead of nill thus the required tag won't work. I will send a PR soon. For now you can restore this file back, i will handle the work in my PR :)
sophieyfang
reviewed
Apr 28, 2022
| @@ -1,5 +1,6 @@ | |||
| short_name: varnish | |||
| long_name: Varnish HTTP Cache | |||
There was a problem hiding this comment.
It also needs Description from the scope doc, it will start failing the test once #567 is in
The Varnish integration collects cache and session metrics. It monitors the number of objects entering and exiting the cache, as well as the number of sessions and backend connections. The integration also collects Varnish access logs and parses them into a standardized json payload.
Signed-off-by: Ridwan Sharif <[email protected]>
Signed-off-by: Ridwan Sharif <[email protected]>
ridwanmsharif
force-pushed
the
ridwanmsharif/fix-config-options
branch
from
3ba5285 to
f1d3d55
Compare
sophieyfang
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds in the configuration option for Varnish and adds validation enforcement for new receivers.