Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Active Directory Domain Services metrics receiver #563

Merged
merged 8 commits into from
Apr 29, 2022
Merged

Add Active Directory Domain Services metrics receiver #563

merged 8 commits into from
Apr 29, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Adds the active_directory_ds metrics receiver.

Depends on #529

@BinaryFissionGames BinaryFissionGames added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 27, 2022
@BinaryFissionGames BinaryFissionGames added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 27, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 27, 2022
@BinaryFissionGames BinaryFissionGames added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 28, 2022
@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review April 28, 2022 00:36
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 28, 2022
@BinaryFissionGames BinaryFissionGames mentioned this pull request Apr 29, 2022
Merged
jefferbrecht
jefferbrecht approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@jefferbrecht jefferbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BinaryFissionGames BinaryFissionGames added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 29, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 29, 2022
@BinaryFissionGames
Copy link
Contributor Author

BinaryFissionGames commented Apr 29, 2022 •
edited
Loading

Running kokoro to make sure the active directory metadata is OK now for #567

I expect the windows tests to still fail for mssql/iis, though.

@BinaryFissionGames
Copy link
Contributor Author

Previous kokoro run, looks like active directory passes but iis/mssql fail due to metadata missing supported_versions:

--- FAIL: TestThirdPartyApps (0.45s)
    --- FAIL: TestThirdPartyApps/windows-2012-r2/iis (249.89s)
    --- FAIL: TestThirdPartyApps/windows-2019/iis (317.38s)
    --- FAIL: TestThirdPartyApps/sql-std-2019-win-2019/mssql (401.21s)
    --- FAIL: TestThirdPartyApps/sql-std-2019-win-2019/iis (402.06s)
    --- PASS: TestThirdPartyApps/windows-2012-r2/active_directory_ds (699.66s)
    --- PASS: TestThirdPartyApps/windows-2019/active_directory_ds (805.84s)
    --- PASS: TestThirdPartyApps/sql-std-2019-win-2019/active_directory_ds (886.72s)

@jefferbrecht jefferbrecht merged commit b8f638d into GoogleCloudPlatform:master Apr 29, 2022
@jefferbrecht
Copy link
Member

The IIS and MSSQL PRs are adding supported_versions so we can ignore that for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferbrecht jefferbrecht jefferbrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BinaryFissionGames @jefferbrecht @kokoro-team @stackdriver-instrumentation-release