confgenerator: add resource_name label using modify fields. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscovalentecastro
changed the title
quentinmit
reviewed
Apr 20, 2022
| @@ -209,7 +209,7 @@ func (l *Logging) generateFluentbitComponents(userAgent string, hostInfo *host.I | |||
| } | |||
| components = append(components, processor.Components(tag, strconv.Itoa(i))...) | |||
| } | |||
| components = append(components, setLogNameComponents(tag, rID, receiver.Type())...) | |||
| components = append(components, setLogNameComponents(tag, rID, receiver.Type(), hostInfo.Hostname)...) | |||
There was a problem hiding this comment.
hostname isn't necessarily the same as the instance name - the resource name has to come from the GCE metadata server
There was a problem hiding this comment.
I went back to explore the initial discussion (b/169784211#comment18) with @igorpeshansky and @qingling128 about this task and realized why it was ok to use hostInfo.Hostname.
The value that is used in google-fluentd (which this feature wants to mirror) is actually the Socket.gethostname which is equivalent of getting os.Hostname in go with gopsutil.
What do you think @quentinmit ?
There was a problem hiding this comment.
Thanks for checking! Yeah, having the same behavior as Fluentd is sufficient for now.
franciscovalentecastro
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
franciscovalentecastro
force-pushed
the
fcovalente-add-resource-name-modify-fields
branch
3 times, most recently
from
fabefab to
341bf44
Compare
franciscovalentecastro
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
franciscovalentecastro
added
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
franciscovalentecastro
force-pushed
the
fcovalente-add-resource-name-modify-fields
branch
from
e0e2825 to
260735b
Compare
franciscovalentecastro
force-pushed
the
fcovalente-add-resource-name-modify-fields
branch
from
149aac2 to
485c65f
Compare
Set label name to `compute.googleapis.com/resource_name` and set label using `DefaultValue` for `modify_fields`.
franciscovalentecastro
force-pushed
the
fcovalente-add-resource-name-modify-fields
branch
from
f9c44ed to
93021a6
Compare
franciscovalentecastro
deleted the
fcovalente-add-resource-name-modify-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/169784211