Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration description #532

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Add integration description #532

merged 3 commits into from
Apr 18, 2022

Conversation

sophieyfang
Copy link
Contributor

b/229635463

@sophieyfang sophieyfang requested a review from qingling128 April 18, 2022 18:43
qingling128
qingling128 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the open thread is addressed.

integration_test/third_party_apps_data/applications/activemq/metadata.yaml Outdated Show resolved Hide resolved
qingling128
qingling128 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophieyfang sophieyfang merged commit 3f665e8 into master Apr 18, 2022
@sophieyfang sophieyfang deleted the sophie-description branch April 18, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophieyfang @qingling128