-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IIS logging #515
Add IIS logging #515
Conversation
integration_test/third_party_apps_data/applications/iis/metadata.yaml
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_data/applications/iis/metadata.yaml
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_data/applications/iis/metadata.yaml
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_data/applications/iis/exercise
Outdated
Show resolved
Hide resolved
Is this information available somewhere in the logs for kokoro? It still seems to be failing and not showing whether or not any logs were detected at all. |
Sort of.
I'm skeptical of all of the backslashes being double-escaped -- Cloud Logging queries accept regex strings as-is and let the underlying regex engine handle unescaping, so those queries are looking for literal backslashes which wasn't the intention. I think it's this. The parts = append(parts, fmt.Sprintf(`%s=~"%s"`, field.Name, field.ValueRegex)) (this change might affect previously-passing tests so there's a chance we'll have to update non-IIS metadata.yaml too -- we'll see what happens with the next Kokoro run after that change) |
I don't seem to access to that. Any chance we can get access? |
I don't think we grant access to that project outside of Google. An alternative would be to run the integration test manually on a GCP project that you do have access to. This describes how to run it (you'll have to pass your GCP project in (but if there are any logs you'd like me to fetch for you from a |
Looks great overall, glad the tests are passing now. Just a few minor threads still open. Mainly the Lua code needs to be updated to delete those three fields, the rest are nits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the last small change in the doc 👍
Add access logging for IIS based off of the W3C format.
Example log