Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added log_entry_count and request_count self-metrics to ops-agent #479

Merged
merged 11 commits into from
May 9, 2022
Merged

Added log_entry_count and request_count self-metrics to ops-agent #479

merged 11 commits into from
May 9, 2022

Conversation

rafaelwestphal
Copy link
Contributor

@rafaelwestphal rafaelwestphal commented Mar 18, 2022 •
edited
Loading 

Added the self metrics log_entry_count and request_count to ops-agent. This relays on metrics exposed by the
fluentbit prometheus endpoint.

@rafaelwestphal rafaelwestphal force-pushed the westphalrafael-fluentbit-log-entry-count branch 2 times, most recently from 00a4688 to b102a91 Compare April 28, 2022 18:37
qingling128
qingling128 reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some integration tests for this? Simply uncommenting

ops-agent/integration_test/ops_agent_test.go

Lines 901 to 904 in 9645814

// TODO(b/170138116): Enable these metrics once they are being collected.
//"agent.googleapis.com/agent/log_entry_count",
//"agent.googleapis.com/agent/log_entry_retry_count",
//"agent.googleapis.com/agent/request_count",
might be sufficient

@rafaelwestphal rafaelwestphal added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 28, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 28, 2022
@rafaelwestphal rafaelwestphal force-pushed the westphalrafael-fluentbit-log-entry-count branch 4 times, most recently from 2b36e50 to efd9f87 Compare May 3, 2022 15:09
@rafaelwestphal rafaelwestphal force-pushed the westphalrafael-fluentbit-log-entry-count branch from efd9f87 to bb08b61 Compare May 6, 2022 19:41
@rafaelwestphal rafaelwestphal changed the title Added remaning logging self-metrics to ops-agent Added log_entry_count and request_count self-metrics to ops-agent May 6, 2022
qingling128
qingling128 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelwestphal rafaelwestphal merged commit ad1b340 into master May 9, 2022
@igorpeshansky igorpeshansky deleted the westphalrafael-fluentbit-log-entry-count branch July 10, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

@davidbtucker davidbtucker Awaiting requested review from davidbtucker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelwestphal @qingling128 @stackdriver-instrumentation-release