Reject redundant entries in supported_applications.txt #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise a test failure if the same application appears more than once in supported_applications.txt. This is to prevent the situation that #432 is fixing from reoccurring.
igorpeshansky
requested changes
Mar 1, 2022
| unique := make(map[string]bool) | ||
| for _, app := range apps { | ||
| if unique[app] { | ||
| return fmt.Errorf("application %q appears multiple times in supported_applications.txt", app) |
There was a problem hiding this comment.
[Optional] Would it make sense to list all duplicates?
There was a problem hiding this comment.
I guess by resolving this you were saying that reporting one duplicate at a time is fine. Well, it was optional anyway. For the record, I was suggesting something like:
func rejectDuplicates(apps []string) error {
seen := make(map[string]bool)
var dups []string
for _, app := range apps {
if seen[app] {
dups = append(dups, app)
}
seen[app] = true
}
if len(dups) > 0 {
return fmt.Errorf("applications %q appear multiple times in supported_applications.txt", dups)
}
return nil
}
igorpeshansky
approved these changes
Mar 4, 2022
| unique := make(map[string]bool) | ||
| for _, app := range apps { | ||
| if unique[app] { | ||
| return fmt.Errorf("application %q appears multiple times in supported_applications.txt", app) |
There was a problem hiding this comment.
I guess by resolving this you were saying that reporting one duplicate at a time is fine. Well, it was optional anyway. For the record, I was suggesting something like:
func rejectDuplicates(apps []string) error {
seen := make(map[string]bool)
var dups []string
for _, app := range apps {
if seen[app] {
dups = append(dups, app)
}
seen[app] = true
}
if len(dups) > 0 {
return fmt.Errorf("applications %q appear multiple times in supported_applications.txt", dups)
}
return nil
}
|
yes, I both think that reporting one duplicate at a time is fine and that the code for reporting all duplicates is more complex and not worth it. So I'll go ahead and proceed with the current approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a test failure if the same application appears more than once in supported_applications.txt. This is to prevent the situation that #432 is fixing from reoccurring.