Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TestCustomLogFormat integration test. #424

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Update TestCustomLogFormat integration test. #424

merged 2 commits into from
Feb 23, 2022

Conversation

franciscovalentecastro
Copy link
Contributor

b/219518200

@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-update-testcustomlogformat branch from d41a13c to dc59c64 Compare February 22, 2022 20:32
@franciscovalentecastro franciscovalentecastro marked this pull request as ready for review February 22, 2022 21:21
franciscovalentecastro
franciscovalentecastro commented Feb 22, 2022
View reviewed changes
integration_test/ops_agent_test.go
line := fmt.Sprintf("<13>1 %s %s my_app_id - - - qqqqrrrr\n", time.Now().Format(time.RFC3339Nano), vm.Name)
// When not using UTC timestamps, the parsing with "%Y-%m-%dT%H:%M:%S.%L%z" doesn't work
// correctly in windows (b/218888265).
line := fmt.Sprintf("<13>1 %s %s my_app_id - - - qqqqrrrr\n", time.Now().UTC().Format(time.RFC3339Nano), vm.Name)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use "UTC" (with no timezone offset) due to the following issue in the Fluent Bit backend when parsing timestamps in Windows.

@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 22, 2022
@kokoro-team kokoro-team removed kokoro:force-run Forces kokoro to run integration tests on a CL labels Feb 22, 2022
@franciscovalentecastro franciscovalentecastro merged commit 4b5def2 into master Feb 23, 2022
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-update-testcustomlogformat branch February 23, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvans martijnvans martijnvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscovalentecastro @martijnvans @kokoro-team