-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ Logging Receiver #411
RabbitMQ Logging Receiver #411
Conversation
…o rabbitmq-logging-receiver
…gent into rabbitmq-logging-receiver
Kokoro passed on commit: subsequent commits are just rebases/readme updates. |
apps/rabbitmq.go
Outdated
}, | ||
{ | ||
"noti", "DEFAULT", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit][formatting] For consistency with the other receivers, could we have all of the pairings be inline with their braces like:
c = append(c, fluentbit.TranslationComponents(tag, "severity", "logging.googleapis.com/severity", true, []struct {
SrcVal string
DestVal string
}{
{"debug", "DEBUG"},
{"error", "ERROR"},
{"info", "INFO"},
{"noti", "DEFAULT"},
}...,
)
apps/rabbitmq.go
Outdated
{ | ||
StateName: "cont", | ||
NextState: "cont", | ||
Regex: `^\s*$`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example in the comments above, will all of
2022-01-31 18:07:43.557042+00:00 [erro] <0.130.0>
BOOT FAILED
===========
ERROR: could not bind to distribution port 25672, it is in use by another node: rabbit@keith-testing-rabbitmq
Be a single LogEntry? The regex multiline rules here suggest that they won't be no?
If we wanted them to be the same LogEntry would this make more sense?:
r.MultilineRules = []confgenerator.MultilineRule{
{
StateName: "start_state",
NextState: "cont",
Regex: `\d+-\d+-\d+ \d+:\d+:\d+\.\d+\+\d+:\d+`,
},
{
StateName: "cont",
NextState: "cont",
Regex: `^(?!\d+-\d+-\d+ \d+:\d+:\d+\.\d+\+\d+:\d+)`,
},
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh that makes more sense, I think I may have misunderstood quite how multiline was working but just tested this out and it appears to work great! Thanks for the suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/rabbitmq.md
Outdated
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Few extra newlines here can be removed
@qingling128 @ridwanmsharif just curious if there is anything preventing this from merging? Thanks again for the reviews! |
The failure seems to be for debian 10 mysql only. And it looks unrelated:
Merging. |
Config
Also resolves small nit for collection interval in mongodb metrics input.yaml from #354