Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default port of Apache. #386

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Fix the default port of Apache. #386

merged 7 commits into from
Feb 8, 2022

Conversation

qingling128
Copy link
Contributor

@qingling128 qingling128 commented Feb 5, 2022

The default port of Apache should be 80 instead of 8080.

Apache users today have to explicitly specifyserver_status_url: http://localhost:80/server-status?auto in their config today to customize the config.

b/207530308

Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@qingling128
Copy link
Contributor Author

Debian test is failing for tomcat, which is a known issue and being fixed by a separate PR.

--- FAIL: TestThirdPartyApps (0.00s)
    --- FAIL: TestThirdPartyApps/debian-10 (0.00s)
        --- PASS: TestThirdPartyApps/debian-10/couchdb (167.13s)
        --- PASS: TestThirdPartyApps/debian-10/postgresql (180.82s)
        --- PASS: TestThirdPartyApps/debian-10/memcached (203.17s)
        --- FAIL: TestThirdPartyApps/debian-10/apache (205.31s)
        --- PASS: TestThirdPartyApps/debian-10/redis (208.86s)
        --- PASS: TestThirdPartyApps/debian-10/solr (236.69s)
        --- PASS: TestThirdPartyApps/debian-10/mysql (242.68s)
        --- PASS: TestThirdPartyApps/debian-10/nginx (248.99s)
        --- PASS: TestThirdPartyApps/debian-10/jvm (249.45s)
        --- PASS: TestThirdPartyApps/debian-10/cassandra (263.35s)
        --- PASS: TestThirdPartyApps/debian-10/mongodb (307.84s)
        --- PASS: TestThirdPartyApps/debian-10/elasticsearch (315.00s)
        --- FAIL: TestThirdPartyApps/debian-10/tomcat (388.75s)

@qingling128 qingling128 merged commit 6e2286b into master Feb 8, 2022
@qingling128 qingling128 deleted the lingshi-port branch February 8, 2022 19:34
martijnvans pushed a commit that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants