Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildfly logging receiver #382

Merged
merged 29 commits into from
Feb 11, 2022
Merged

Wildfly logging receiver #382

merged 29 commits into from
Feb 11, 2022

Conversation

dehaansa
Copy link
Contributor

@dehaansa dehaansa commented Feb 3, 2022

image

Named wildfly_server as there are wildfly audit logs that we are not targeting for this effort according to the agreed upon spec, but I wanted to leave room for their addition in the future without feeling like a rename would be appropriate.

@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 4, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 7, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 7, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 7, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 7, 2022
@dehaansa dehaansa marked this pull request as ready for review February 7, 2022 19:07
@dehaansa
Copy link
Contributor Author

dehaansa commented Feb 7, 2022

Current debian failures include tomcat & mysql, wildfly is passing.

    --- FAIL: TestThirdPartyApps/debian-10 (0.00s)
        --- PASS: TestThirdPartyApps/debian-10/elasticsearch (292.62s)
        --- PASS: TestThirdPartyApps/debian-10/redis (349.54s)
        --- PASS: TestThirdPartyApps/debian-10/couchdb (369.34s)
        --- PASS: TestThirdPartyApps/debian-10/postgresql (383.98s)
        --- PASS: TestThirdPartyApps/debian-10/wildfly (425.24s)
        --- PASS: TestThirdPartyApps/debian-10/memcached (435.71s)
        --- PASS: TestThirdPartyApps/debian-10/apache (454.81s)
        --- PASS: TestThirdPartyApps/debian-10/mongodb (456.58s)
        --- PASS: TestThirdPartyApps/debian-10/jvm (489.18s)
        --- PASS: TestThirdPartyApps/debian-10/cassandra (492.70s)
        --- PASS: TestThirdPartyApps/debian-10/nginx (497.46s)
        --- PASS: TestThirdPartyApps/debian-10/solr (501.21s)
        --- FAIL: TestThirdPartyApps/debian-10/mysql (989.27s)
        --- FAIL: TestThirdPartyApps/debian-10/tomcat (1004.48s)```

@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 10, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 10, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 10, 2022
@kokoro-team kokoro-team removed kokoro:force-run Forces kokoro to run integration tests on a CL labels Feb 10, 2022
@dehaansa
Copy link
Contributor Author

dehaansa commented Feb 10, 2022

As of commit bab6dcb all integration tests passing other than known postgresql issues.

Outstanding concerns:
Investigating domain controller logs to see if they are formatted the same and can be dropped in without issue. #382 (comment)
Waiting @qingling128 's perspective on naming comment #382 (comment)

Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM module @ridwanmsharif 's feedback is addressed. I also left some minor comments.

@ridwanmsharif Feel free to merge if the comments are addressed and tests passed. (aka I will check back periodically, too. But another round of reviews by me is not required, as the feedback is minor.)

docs/wildfly.md Show resolved Hide resolved
apps/wildfly.go Outdated Show resolved Hide resolved
docs/wildfly.md Outdated Show resolved Hide resolved
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
Copy link
Contributor

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge after we decide on the ./domain/log/*.log files

apps/wildfly.go Show resolved Hide resolved
@dehaansa
Copy link
Contributor Author

dehaansa commented Feb 11, 2022

Re: #382 (comment) - hoping to have this well understood early Monday, so this'll have to wait until then.

Edit: got this figured out faster than anticipated, it's supported. Added some examples to the comments, and updated default paths & named _system as noted by Ling. Once kokoro's running well again will get this validated so we can push forward.

@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@ridwanmsharif ridwanmsharif added kokoro:force-run Forces kokoro to run integration tests on a CL and removed kokoro:force-run Forces kokoro to run integration tests on a CL labels Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 11, 2022
@ridwanmsharif ridwanmsharif merged commit a66510e into GoogleCloudPlatform:master Feb 11, 2022
@dehaansa dehaansa deleted the wildfly-logging branch February 11, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants