-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildfly logging receiver #382
Wildfly logging receiver #382
Conversation
Current debian failures include tomcat & mysql, wildfly is passing.
|
As of commit bab6dcb all integration tests passing other than known postgresql issues. Outstanding concerns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM module @ridwanmsharif 's feedback is addressed. I also left some minor comments.
@ridwanmsharif Feel free to merge if the comments are addressed and tests passed. (aka I will check back periodically, too. But another round of reviews by me is not required, as the feedback is minor.)
confgenerator/testdata/valid/linux/logging-receiver_wildfly/input.yaml
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_data/agent/ops-agent/linux/enable_wildfly
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_data/applications/wildfly/centos_rhel/install
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge after we decide on the ./domain/log/*.log
files
Re: #382 (comment) - hoping to have this well understood early Monday, so this'll have to wait until then. Edit: got this figured out faster than anticipated, it's supported. Added some examples to the comments, and updated default paths & named _system as noted by Ling. Once kokoro's running well again will get this validated so we can push forward. |
Named wildfly_server as there are wildfly audit logs that we are not targeting for this effort according to the agreed upon spec, but I wanted to leave room for their addition in the future without feeling like a rename would be appropriate.