Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try reenabling mysql tests #361

Merged
merged 5 commits into from
Feb 5, 2022
Merged

Conversation

martijnvans
Copy link
Contributor

mysql tests were completely broken, let's see if they are fixed now.

mysql tests were completely broken, let's see if they are fixed now.
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 26, 2022
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 26, 2022
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 26, 2022
@dehaansa
Copy link
Contributor

Should be resolvable by downloading the correct GPG key ahead of the apt update after installing the mysql repo. Found this information here

sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 467B942D3A79BD29

@martijnvans martijnvans requested a review from dehaansa February 4, 2022 22:15
@martijnvans martijnvans marked this pull request as ready for review February 4, 2022 22:15
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingling128
Copy link
Contributor

qingling128 commented Feb 5, 2022

Tests passed for mysql (the only failure is debian 10 tomcat, which is a known issue that is being addressed by a separate PR):
image

OK to merge. Needs rebasing.

@qingling128 qingling128 merged commit 07b3b91 into master Feb 5, 2022
@qingling128 qingling128 deleted the martijnvans-reenaable-mysql branch February 5, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants