Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couchdb Metrics Receiver #340

Merged
merged 14 commits into from
Feb 4, 2022
Merged

Couchdb Metrics Receiver #340

merged 14 commits into from
Feb 4, 2022

Conversation

JonathanWamsley
Copy link
Contributor

@JonathanWamsley JonathanWamsley commented Jan 21, 2022

Add support for Couchdb Metrics.

NOTE: SLES is not supported natively by Couchdb.

@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 24, 2022
@kokoro-team kokoro-team removed kokoro:force-run Forces kokoro to run integration tests on a CL labels Jan 24, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 24, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 24, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 24, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 24, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 25, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 25, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 25, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 31, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@JonathanWamsley
Copy link
Contributor Author

The ops agent integration test had an unrelated failure on TestLoggingAgentCrashRestart failed failed sles test

@JonathanWamsley
Copy link
Contributor Author

The third party apps integration test passed for couchdb but failed an unrelated test on tomcat tomcat test

@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 1, 2022
docs/couchdb.md Outdated Show resolved Hide resolved
docs/couchdb.md Outdated Show resolved Hide resolved
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 2, 2022
docs/couchdb.md Outdated Show resolved Hide resolved

sudo yum install -y couchdb

cat << EOF > local.ini
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you use the default configuration instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@qingling128
Copy link
Contributor

Overall LGTM modulo the remaining 3 open threads are addressed, and the integration tests are fixed (Probably some minor issue triggered by the suggested renaming):

image

@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@JonathanWamsley JonathanWamsley added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 3, 2022
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Needs rebasing before merging. If the conflicts are limited to the golden files, we can skip running the integration tests again, as they passed already.

@@ -0,0 +1,20 @@
# Couchdb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for Jimmy, the full documentation can be found in https://github.com/GoogleCloudPlatform/ops-agent/blob/90d604b692cffb9cf388948e586cf5e2a894b2d0/docs/couchdb.md

Note for future reference: Currently we are trying to automate the documentation generation for https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/third-party. Before that is completed, the workflow is:

  1. ObserveIQ contributes documentation (in the format of https://github.com/GoogleCloudPlatform/ops-agent/blob/90d604b692cffb9cf388948e586cf5e2a894b2d0/docs/couchdb.md) as docs/{APP_NAME}.md files.
  2. Jimmy to take these markdown and turn them into the expected format for https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/third-party
  3. We then comes back to GitHub to delete the install instructions to avoid maintaining two copies for the long term after https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/third-party/{APP_NAME} is published.

@qingling128 qingling128 merged commit ba4465d into GoogleCloudPlatform:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants