Use httpRequest field rename
#312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
requested review from
a team and
igorpeshansky
and removed request for
a team
|
Looks like the Ngnix and Apache tests are failing: BTW, looks like we don't have coverage for http request in ops_agent_test.go (internal). Can we add a test case there? |
braydonk
force-pushed
the
braydonk-field-rename
branch
from
2c8486f to
9546d8a
Compare
qingling128
approved these changes
Feb 16, 2022
|
Thanks Ling, I'll clean this up once my change is released in fluent-bit upstream (likely in 1.8.13). |
braydonk
force-pushed
the
braydonk-field-rename
branch
from
9546d8a to
b8d03d1
Compare
This was a FIXME comment that I forgot to remove when I fixed the thing it was referring to.
braydonk
force-pushed
the
braydonk-field-rename
branch
from
b8d03d1 to
75472dd
Compare
braydonk
force-pushed
the
braydonk-field-rename
branch
from
75472dd to
9531df6
Compare
braydonk
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
igorpeshansky
requested changes
Jun 1, 2022
...lid/linux/metrics-receiver_redis_missing_address/golden_8f841e1624ad9de1bb98322777b1ac10.lua
Outdated
Show resolved
Hide resolved
I think as a result of sloppy Git rebasing I left some new generated goldens for an old deleted test in my last commit.
Add a new sub test case that will also check that the old field is not parsed. Also added a check that the field is stripped from the message as expected.
Changed wording of a comment and some variable names for clarity. Changed log query to quote the log ID.
|
Will update this branch once I see these integration tests work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in fluent/fluent-bit#4200 fluent-bit is using a name for
logging.googleapis.com/httpRequestthat is inconsistent (i.e.logging.googleapis.com/http_request). To allow for a non-breaking fix, this PR uses a feature added to fluent-bit that allows the user to override this key.