Install OpenSSL on Windows. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpeshansky
requested changes
Nov 17, 2021
jkschulz
force-pushed
the
jschulz-windows-ssl
branch
from
c321868 to
e53d1d4
Compare
jkschulz
dismissed
igorpeshansky’s stale review
addressed. idk why "re-request review" isn't showing up as an option here anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://b/206154592
Fluent Bit uses either mbedtls or OpenSSL for TLS, and will default to OpenSSL if it's able to find its headers. There's a bug in mbedtls that's causing connection issues (see fluent/fluent-bit#4300 (comment)), so we'll build with OpenSSL instead. Our Linux builds already install OpenSSL, so this will also make Windows consistent.
Build and test info: http://b/206154592#comment2