Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version of prometheus and OTel SDK #1786

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Aug 29, 2024

Description

This PR updates the version of Prometheus used by the Ops Agent; this is where we pull the structs for the Prometheus configuration (unrelated to the version of Prometheus used by the collector subagent).

Updates to the OTel SDK and Google Cloud Exporter were necessary for the module update to reconcile.

The following commands were used:

go get -u github.com/prometheus/prometheus@latest
go get -u go.opentelemetry.io/otel/sdk/metric@latest
go get -u github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric@latest

Then I had to adjust for the fact that the aggregation package has been removed from the SDK.

Related issue

How has this been tested?

It builds and all unit tests pass locally.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@jefferbrecht jefferbrecht added the kokoro:force-run Forces kokoro to run integration tests on a CL label Sep 17, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Sep 17, 2024
Copy link
Member

@jefferbrecht jefferbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures look unrelated

@braydonk braydonk merged commit 4fb9aad into master Sep 18, 2024
57 of 60 checks passed
@braydonk braydonk deleted the braydonk-fix-deps branch September 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants