Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit slash-dot for copy paths #1781

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jefferbrecht
Copy link
Member

Description

Follow-on to #1761. filepath.Join(directory, ".") can trim the dot away which messes up the gcloud config copy operation; this PR adds the dot explicitly without using filepath.Join.

Related issue

b/352054649

How has this been tested?

Tested and succeeded locally.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jefferbrecht jefferbrecht merged commit 3c3db61 into master Aug 21, 2024
59 of 63 checks passed
@jefferbrecht jefferbrecht deleted the jefferbrecht-gcloud-copy-contents branch August 21, 2024 18:06
@jefferbrecht
Copy link
Member Author

Failures look unrelated; merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants