-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and update metadata files for IIS, MSSQL, and MySQL/MariaDB. #1777
Conversation
2e35b05
to
e8934ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc-related files look fine to me.
Also don't crash on empty feature lists in third-party tests.
Use the first matching reason for skipping the test platform.
2a1542c
to
6763932
Compare
integration_test/third_party_apps_test/applications/mariadb/metadata.yaml
Outdated
Show resolved
Hide resolved
integration_test/third_party_apps_test/applications/mssql/metadata.yaml
Outdated
Show resolved
Hide resolved
eb74799
to
4f26a11
Compare
4f26a11
to
46c13a2
Compare
Sure, either that or overwriting the built-in |
Right, putting them in the |
Description
Bring the third-party
metadata.yaml
files for IIS, MSSQL, and MySQL/MariaDB up-to-date with the public docs, in preparation for eventually using them as the source of truth.A follow-on to #1772.
Related issue
b/240700717
b/356682372
How has this been tested?
All of the
metadata.yaml
changes have been run through an automatic doc generator and compared with the existing documentation. The added third-party application tests have passed.Checklist: