Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider case when optional log fields may be missing in third_party_apps_tests. #1776

Merged

Conversation

franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Aug 8, 2024

Description

Currently constructQuery doesn't consider the case where an optional log field may be completely missing (see missing fields in log query language).

When vault was upgraded from 1.17.2 to 1.17.3, the field jsonPayload.auth is omitted when token_type=default. See hashicorp/vault@v1.17.2...v1.17.3 . Setting jsonPayload.auth as optional due to this update.

Related issue

b/358355216

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro requested review from igorpeshansky and a team and removed request for a team August 9, 2024 15:48
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@franciscovalentecastro franciscovalentecastro merged commit 67773af into master Aug 9, 2024
59 of 62 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-fix-3p-test-optional-fields branch August 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants