Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Apache web server configuration into the application install scripts. #1762

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Inline Apache web server configuration into the application install scripts. #1762

merged 7 commits into from
Aug 5, 2024

Conversation

igorpeshansky
Copy link
Member

Description

Use the inline configuration when installing Apache web server in tests.

How has this been tested?

Integration tests.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@igorpeshansky igorpeshansky force-pushed the igorpeshansky-inline-apache-config branch from 9061322 to f756dab Compare July 26, 2024 03:40
@igorpeshansky igorpeshansky force-pushed the igorpeshansky-inline-apache-config branch from 4f3266c to 2d268f7 Compare July 26, 2024 05:56
martijnvans
martijnvans reviewed Aug 3, 2024
View reviewed changes
Copy link
Contributor

@martijnvans martijnvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment up above asking why the configuration directory changed in this PR.

igorpeshansky and others added 2 commits August 5, 2024 12:25
@igorpeshansky
Merge branch 'master' into igorpeshansky-inline-apache-config
b6e4066
@igorpeshansky
Reapply "Testing: curl server-status"
9fb0f55 
This gives a clear indication in tests that mod_status has been set up
properly, making it easier to debug any issues.
@igorpeshansky igorpeshansky force-pushed the igorpeshansky-inline-apache-config branch from b69ff61 to 9fb0f55 Compare August 5, 2024 16:36
@igorpeshansky
Copy link
Member Author

Apache third-party tests succeeded on all platforms. Merging.

@igorpeshansky igorpeshansky merged commit b393242 into master Aug 5, 2024
60 of 63 checks passed
@igorpeshansky igorpeshansky deleted the igorpeshansky-inline-apache-config branch August 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvans martijnvans martijnvans approved these changes

@jefferbrecht jefferbrecht Awaiting requested review from jefferbrecht

@braydonk braydonk Awaiting requested review from braydonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpeshansky @martijnvans