Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use environment variables for file list arguments. #1759

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Use environment variables for file list arguments. #1759

merged 1 commit into from
Jul 22, 2024

Conversation

igorpeshansky
Copy link
Member

Description

It's easier to include file lists verbatim if they are in environment variables.

Related issue

b/349924588

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@igorpeshansky igorpeshansky requested a review from LujieDuan July 19, 2024 16:40
@igorpeshansky
Copy link
Member Author

/cc @Zzz-- @serb-google

LujieDuan
LujieDuan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@LujieDuan LujieDuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igorpeshansky igorpeshansky merged commit 8fbb478 into master Jul 22, 2024
69 checks passed
@igorpeshansky igorpeshansky deleted the igorpeshansky-github-actions branch July 22, 2024 20:20
igorpeshansky added a commit that referenced this pull request Aug 2, 2024
@igorpeshansky
Use environment variables for file list arguments. (#1759)
68b4a6d
igorpeshansky added a commit that referenced this pull request Aug 2, 2024
@igorpeshansky
Use environment variables for file list arguments. (#1759)
0cb2eed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LujieDuan LujieDuan LujieDuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpeshansky @LujieDuan