Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to specify gcloud configuration directory in tests. #1750

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add the ability to specify gcloud configuration directory in tests. #1750

merged 1 commit into from
Jul 11, 2024

Conversation

igorpeshansky
Copy link
Member

Description

Add the ability to specify a unique gcloud configuration directory per test.
This should prevent errors like:

ERROR: (gcloud.beta.compute.instances.create) You do not currently have an active account selected.

Also fix a compilation bug in agents.go that manifests with newer Go versions.

Related issue

b/352054649

How has this been tested?

Integration tests.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@igorpeshansky igorpeshansky marked this pull request as ready for review July 11, 2024 07:40
braydonk
braydonk approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpeshansky igorpeshansky merged commit 912e518 into master Jul 11, 2024
70 checks passed
@igorpeshansky igorpeshansky deleted the igorpeshansky-gcloud-config-context branch July 11, 2024 17:36
@igorpeshansky igorpeshansky mentioned this pull request Jul 25, 2024
Merged
9 tasks
igorpeshansky added a commit that referenced this pull request Aug 2, 2024
@igorpeshansky
Add the ability to specify gcloud configuration directory in tests. (#…
80a29de 
…1750)

Also fix a compilation bug in agents.go that manifests with newer Go versions.
igorpeshansky added a commit that referenced this pull request Aug 2, 2024
@igorpeshansky
Add the ability to specify gcloud configuration directory in tests. (#…
6c21bc4 
…1750)

Also fix a compilation bug in agents.go that manifests with newer Go versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braydonk braydonk braydonk approved these changes

@martijnvans martijnvans martijnvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorpeshansky @martijnvans @braydonk