-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change syslog dependency to Recommends #1747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Debian 11 failure is a flake. The rest of the failures are expected and unrelated to this change. @igorpeshansky do you think this should be merged now or should we wait til those CI failures are resolved? This is slated for 2.49.0 but so are the fixes causing the CI failures in the PR anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
While a syslog daemon is required for full desired Ops Agent functionality, our previous reliance on the presence of a syslog daemon was provided by the dependency specified in the
google-compute-engine
package, which is aRecommends
dependency.This PR changes the syslog daemon dependency in the Ops Agent deb package to
Recommends
instead ofDepends
.Related issue
b/339061751
How has this been tested?
Manually tested the workflow where we install Ops Agent without installing
rsyslog
:make build
to get a localdeb
package.Created a new Debian 12 GCE VM.
Remove
rsyslog
from the VM:Copied the deb package to the VM. Install it without installing Recommended packages:
rsyslog
was not installed, verified with:Checklist: