Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change syslog dependency to Recommends #1747

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Jul 3, 2024

Description

While a syslog daemon is required for full desired Ops Agent functionality, our previous reliance on the presence of a syslog daemon was provided by the dependency specified in the google-compute-engine package, which is a Recommends dependency.

This PR changes the syslog daemon dependency in the Ops Agent deb package to Recommends instead of Depends.

Related issue

b/339061751

How has this been tested?

Manually tested the workflow where we install Ops Agent without installing rsyslog:

make build to get a local deb package.
Created a new Debian 12 GCE VM.
Remove rsyslog from the VM:

sudo apt purge rsyslog

Copied the deb package to the VM. Install it without installing Recommended packages:

sudo apt install --no-install-recommends ./google-cloud-ops-agent_2.49.0~debian12_amd64.deb

rsyslog was not installed, verified with:

dpkg -l | grep rsyslog

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

debian/control Show resolved Hide resolved
@braydonk braydonk requested review from igorpeshansky July 3, 2024 18:51
@braydonk braydonk added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 3, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 3, 2024
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

debian/control Show resolved Hide resolved
@braydonk braydonk added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 5, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 5, 2024
@braydonk
Copy link
Contributor Author

braydonk commented Jul 5, 2024

Debian 11 failure is a flake. The rest of the failures are expected and unrelated to this change.

@igorpeshansky do you think this should be merged now or should we wait til those CI failures are resolved? This is slated for 2.49.0 but so are the fixes causing the CI failures in the PR anyway.

Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@braydonk braydonk merged commit e75ad21 into master Jul 9, 2024
15 of 29 checks passed
@igorpeshansky igorpeshansky deleted the braydonk-rsyslog-recommends branch July 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants