Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Print all arguments passed to service #1746

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Windows: Print all arguments passed to service #1746

merged 1 commit into from
Jul 5, 2024

Conversation

jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Jul 3, 2024 •
edited by igorpeshansky
Loading

Description

Previously we were only printing the service start arguments (which we don't populate) and not the actual command-line arguments (which we do populate).

Also remove a line that was printing garbage.

Related issue

b/333974153

How has this been tested?

Will let presubmits run

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

igorpeshansky
igorpeshansky approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jefferbrecht
Print all arguments passed to service
43630c4 
Previously we were only printing the service start arguments (which we
don't populate) and not the actual command-line arguments (which we do
populate).

Also remove a line that was printing garbage.
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-windows-args branch from 2d5f2a9 to 43630c4 Compare July 4, 2024 18:01
@jefferbrecht
Copy link
Member Author

Mix of presubmit errors, all seem to be unrelated to this change -- merging.

@jefferbrecht jefferbrecht merged commit 4b3b749 into master Jul 5, 2024
66 of 75 checks passed
@jefferbrecht jefferbrecht deleted the jefferbrecht-windows-args branch July 5, 2024 15:20
igorpeshansky pushed a commit that referenced this pull request Aug 2, 2024
@jefferbrecht @igorpeshansky
Windows: Print all arguments passed to service (#1746)
3bbc08b
igorpeshansky pushed a commit that referenced this pull request Aug 2, 2024
@jefferbrecht @igorpeshansky
Windows: Print all arguments passed to service (#1746)
f1e4082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jefferbrecht @igorpeshansky