Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sles15 sap image family #1743

Merged
merged 12 commits into from
Jul 9, 2024
Merged

update sles15 sap image family #1743

merged 12 commits into from
Jul 9, 2024

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Jun 27, 2024 •
edited by igorpeshansky
Loading

Description

Adding the new image family sles-15-sp6-sap to our tests.

Related issue

b/349706126

How has this been tested?

Integration tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

igorpeshansky
igorpeshansky approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jefferbrecht jefferbrecht force-pushed the braydonk-add-sles-15-sp6 branch from ce685f1 to b1334cc Compare June 28, 2024 13:21
@braydonk braydonk force-pushed the braydonk-add-sles-15-sp6 branch from 531663a to 88562f5 Compare July 3, 2024 18:17
@braydonk
Copy link
Contributor Author

braydonk commented Jul 9, 2024

The remaining CI failures were due to the test-vendors repo mishap in our test infrastructure and EOL distros that are in the process of being removed. Most recent commit was just a comment that won't change the previous CI outcome.

Based on this, merging the PR now.

@igorpeshansky igorpeshansky merged commit e2e1fe5 into master Jul 9, 2024
58 of 75 checks passed
@igorpeshansky igorpeshansky deleted the braydonk-add-sles-15-sp6 branch July 9, 2024 17:20
igorpeshansky pushed a commit that referenced this pull request Aug 2, 2024
@braydonk @igorpeshansky
update sles15 sap image family (#1743)
b6ac70c
igorpeshansky pushed a commit that referenced this pull request Aug 2, 2024
@braydonk @igorpeshansky
update sles15 sap image family (#1743)
5a2060f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

@dehaansa dehaansa dehaansa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braydonk @dehaansa @igorpeshansky