Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: move louhi-specific codename logic #1730

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Internal: move louhi-specific codename logic #1730

merged 4 commits into from
Jun 5, 2024

Conversation

Subbarker
Copy link
Contributor

@Subbarker Subbarker commented Jun 5, 2024 •
edited by igorpeshansky
Loading

Description

Related issue

b/337841307

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

igorpeshansky
igorpeshansky reviewed Jun 5, 2024
View reviewed changes
kokoro/scripts/test/go_test.sh Outdated Show resolved Hide resolved
kokoro/scripts/test/go_test.sh Show resolved Hide resolved
igorpeshansky
igorpeshansky approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Subbarker Subbarker merged commit 418de62 into master Jun 5, 2024
30 of 36 checks passed
@Subbarker Subbarker deleted the subbarker-louchi-repo-name branch June 5, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Subbarker @igorpeshansky