Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Update IsSUSE and call to prepareSLES. #1720

Merged
merged 5 commits into from
May 22, 2024
Merged

Testing: Update IsSUSE and call to prepareSLES. #1720

merged 5 commits into from
May 22, 2024

Conversation

franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented May 22, 2024 •
edited
Loading

Description

This PR attempts to update the uses of IsSUSE, calls to prepareSLES and overall preparation requisites to run tests correctly on a SUSE VM.

Additionally fixes the following error by calling prepareSLES when the ImageSpec is stackdriver-test-143416:sles-15-sp4-sap-saphana which is a special case, which wasn't failing before when using Platform :

Problem retrieving files from 'SLE-Module-Basesystem15-SP4-Pool'.
Credentials are invalid. For details see "/var/log/cloudregister". Re-register the system with "registercloudguest --force-new"
Please see the above error message for a hint.

Related PRs :

Related issue

b/339815782

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro force-pushed the fcovalente-fix-sles15-saphana branch from 63aaa20 to e59ebf7 Compare May 22, 2024 15:22
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label May 22, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label May 22, 2024
igorpeshansky
igorpeshansky reviewed May 22, 2024
View reviewed changes
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
integration_test/gce/gce_testing.go Outdated
}

func IsSUSE(vm_OS_ID string) bool {
return vm_OS_ID == "opensuse" || vm_OS_ID == "opensuse-leap" || vm_OS_ID == "sles" || vm_OS_ID == "sles_sap"
}

func IsCentOS(imageSpec string) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we plan to change the rest of these functions in a subsequent PR? Or fold it into this one?

If we change them all to operate on the vm instead of vm.ImageSpec, we can clean them up one-by-one later…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> Should we plan to change the rest of these functions in a subsequent PR?
I think we should update the rest of the functions, but i do expect unforseen consequences (other failures), so i propose to do the other updates in a followup PR.

Subbarker
Subbarker previously approved these changes May 22, 2024
View reviewed changes
@Subbarker Subbarker dismissed their stale review May 22, 2024 18:13

tests failing

@Subbarker
Copy link
Contributor

It looks like the soak test launcher test has a failure related to your change

@franciscovalentecastro
Copy link
Contributor Author

franciscovalentecastro commented May 22, 2024 •
edited
Loading

It looks like the soak test launcher test has a failure related to your change

Yes, they were from my change. It was because i tried to call getOS before waitForStart, which i realized it won't work since getOS ssh's and run a command. I reverted the order and made sure within waitForStartLinux we use IsSUSEImageSpec, because the vm.OS.ID is not set at that moment.

Most SLES tests are passing (see a9d7330) and most importantly third party apps integration test (SAP HANA x86_64) passed, which was the one i wanted to fix. SLES 15 AArch64 failed in TestExcludeWorkloadMetrics which wasn't a VM setup failure, seems unrelated. There is failure in Ops Agent integration test (Rocky Linux 8 x86_64) and third party apps integration test (CentOS 7 x86_64), but i think they are flakes unrelated to this PR.

@franciscovalentecastro franciscovalentecastro mentioned this pull request May 22, 2024
Merged
9 tasks
@franciscovalentecastro franciscovalentecastro merged commit 955360c into master May 22, 2024
74 of 75 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-fix-sles15-saphana branch May 22, 2024 21:47
@franciscovalentecastro
Copy link
Contributor Author

franciscovalentecastro commented May 22, 2024 •
edited
Loading

Most tests on 4f19034 passed, only Ops Agent integration test (Ubuntu 23.10 Mantic) fail which didn't fail in previous run, so it's most probably a flake.

@franciscovalentecastro franciscovalentecastro mentioned this pull request May 28, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky left review comments

@Subbarker Subbarker Subbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franciscovalentecastro @Subbarker @igorpeshansky @stackdriver-instrumentation-release