Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Update no gpu test to check otel config #1715

Merged
merged 4 commits into from
May 17, 2024

Conversation

LujieDuan
Copy link
Contributor

Description

Update TestNoNvmlOtelReceiverWithoutGpu to check the generated otel config and assert that nvml receiver is not in the generated config when the VM has no GPU.

Related issue

b/341109955

How has this been tested?

Integration test passing.
Tested locally to make sure the test reports correct error when the generated otel config is not presented in the VM.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two optional comments, aside from that LGTM!

integration_test/ops_agent_test/main_test.go Outdated Show resolved Hide resolved
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
@LujieDuan LujieDuan merged commit ee9838c into master May 17, 2024
74 of 75 checks passed
@LujieDuan LujieDuan deleted the lujieduan-fix-no-gpu-test branch May 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants