-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MS SQL Server Errorlog Support #1687
Closed
Caleb-Hurshman
wants to merge
16
commits into
GoogleCloudPlatform:master
from
Caleb-Hurshman:feat/mssql-errorlog-support
Closed
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
83dfdc5
add mssql errorlog support
Caleb-Hurshman d99edae
re-trigger CLA check
Caleb-Hurshman 227706d
fix log paths, other feedback
Caleb-Hurshman fbb2a16
correct windows path
Caleb-Hurshman f914340
C://
Caleb-Hurshman a5a18db
confgenerator test
Caleb-Hurshman 7c0f3b5
force kokoro testing
Caleb-Hurshman 37fe5c8
force kokoro testing v2
Caleb-Hurshman 33ef9f5
fix enable script typo
Caleb-Hurshman b960a1e
fix windows path
Caleb-Hurshman 6525147
fix input script typo
Caleb-Hurshman 9986a16
test confgenerator update
Caleb-Hurshman 94a2b0a
rename receiver in enable script
Caleb-Hurshman e63eb57
Merge branch 'master' into feat/mssql-errorlog-support
Caleb-Hurshman 12e8005
retry make confgenerator
Caleb-Hurshman 9d0e99f
Merge branch 'feat/mssql-errorlog-support' of https://github.com/Cale…
Caleb-Hurshman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
confgenerator/testdata/goldens/all-quoted_map_keys/golden/windows-2012/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
confgenerator/testdata/goldens/all-quoted_map_keys/golden/windows/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...ldens/invalid-logging-processor_parse_multiline_empty_languages/golden/windows-2012/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...ta/goldens/invalid-logging-processor_parse_multiline_empty_languages/golden/windows/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...gging-processor_parse_multiline_missing_required_language_field/golden/windows-2012/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...id-logging-processor_parse_multiline_missing_required_language_field/golden/windows/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...ging-processor_parse_multiline_missing_required_match_any_field/golden/windows-2012/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...d-logging-processor_parse_multiline_missing_required_match_any_field/golden/windows/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
...lid-logging-processor_parse_multiline_more_than_three_languages/golden/windows-2012/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
2 changes: 1 addition & 1 deletion
2
.../invalid-logging-processor_parse_multiline_more_than_three_languages/golden/windows/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. | ||
logging receiver with type "systemd_journald" is not supported. Supported logging receiver types: [active_directory_ds, apache_access, apache_error, cassandra_debug, cassandra_gc, cassandra_system, couchbase_general, couchbase_goxdcr, couchbase_http_access, couchdb, elasticsearch_gc, elasticsearch_json, files, flink, fluent_forward, hadoop, hbase_system, iis_access, jetty_access, kafka, mongodb, mssql_errorlog, mysql_error, mysql_general, mysql_slow, nginx_access, nginx_error, oracledb_alert, oracledb_audit, postgresql_general, rabbitmq, redis, saphana, solr_system, syslog, tcp, tomcat_access, tomcat_system, varnish, vault_audit, wildfly_system, windows_event_log, zookeeper_general]. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the Regex, we need the parser shared section that tells fluentbit how to parse the timestamp. the one below is copied from saphana so it's not the right field/format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR calls this out:
I can add these comments in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll add the comment and see how the ops-agent team would like to handle it.