-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Set image projects via configs #1663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subbarker
added
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Apr 3, 2024
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Apr 3, 2024
martijnvans
reviewed
Apr 4, 2024
martijnvans
reviewed
Apr 4, 2024
martijnvans
reviewed
Apr 4, 2024
Subbarker
added
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Apr 8, 2024
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Apr 8, 2024
Subbarker
added
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Apr 10, 2024
stackdriver-instrumentation-release
removed
the
kokoro:force-run
Forces kokoro to run integration tests on a CL
label
Apr 10, 2024
martijnvans
reviewed
Apr 10, 2024
martijnvans
reviewed
Apr 10, 2024
martijnvans
reviewed
Apr 11, 2024
martijnvans
approved these changes
Apr 11, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a clean start from #1643
Right now we interpret image names passed in from configs to determine what project they come from, and where they are an "Image" or an "Image Family". This logic has grown in complexity over time and most importantly, requires changes to our testing logic whenever a new corner case shows up.
This PR implements storing project names alongside the image/family names with test configs in a way that is simple to manage for future tests. We are calling these strings "Image Specs"
E.g.:
Image Family / Project:
<project>:<family>
Specific Image / Project:
<project>=<image>
Related issue
b/330177642
How has this been tested?
Checklist: