Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Set image projects via configs #1663

Merged
merged 52 commits into from
Apr 11, 2024
Merged

Conversation

Subbarker
Copy link
Contributor

@Subbarker Subbarker commented Apr 2, 2024

Description

This is a clean start from #1643

Right now we interpret image names passed in from configs to determine what project they come from, and where they are an "Image" or an "Image Family". This logic has grown in complexity over time and most importantly, requires changes to our testing logic whenever a new corner case shows up.

This PR implements storing project names alongside the image/family names with test configs in a way that is simple to manage for future tests. We are calling these strings "Image Specs"

E.g.:

Image Family / Project: <project>:<family>

Specific Image / Project: <project>=<image>

Related issue

b/330177642

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Subbarker Subbarker added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 3, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 3, 2024
@Subbarker Subbarker requested a review from martijnvans April 4, 2024 16:24
@Subbarker Subbarker marked this pull request as ready for review April 4, 2024 16:24
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
integration_test/gce/gce_testing.go Show resolved Hide resolved
integration_test/gce/gce_testing.go Show resolved Hide resolved
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
project.yaml Outdated Show resolved Hide resolved
@Subbarker Subbarker added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 8, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 8, 2024
@Subbarker Subbarker added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 10, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 10, 2024
integration_test/gce/gce_testing.go Show resolved Hide resolved
integration_test/gce/gce_testing.go Show resolved Hide resolved
integration_test/gce/gce_testing.go Outdated Show resolved Hide resolved
integration_test/metadata/integration_metadata.go Outdated Show resolved Hide resolved
integration_test/third_party_apps_test.go Show resolved Hide resolved
@Subbarker Subbarker merged commit 1222a10 into master Apr 11, 2024
62 of 69 checks passed
@Subbarker Subbarker deleted the subbarker-project-prefix branch April 11, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants