Changing log compression to an experimental feature #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinmit
reviewed
Jan 8, 2024
| @@ -547,7 +547,7 @@ func (m *loggingProcessorMap) UnmarshalYAML(ctx context.Context, unmarshal func( | |||
| } | |||
|
|
|||
| type LoggingService struct { | |||
| Compress string `yaml:"compress,omitempty" validate:"omitempty,oneof=gzip"` | |||
| Compress string `yaml:"compress,omitempty" validate:"omitempty,oneof=gzip,experimental=log_compression"` | |||
There was a problem hiding this comment.
I think this will cause the confgenerator test to fail now, so you probably need to add this to the init in confgenerator_test.go (or regenerate the goldens if you want the unit test to just capture the error)
quentinmit
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving log compression to an experiment feature
Related issue
How has this been tested?
Checklist: