Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus: add instance name to namespace label #1565

Merged
merged 3 commits into from
Jan 12, 2024
Merged

prometheus: add instance name to namespace label #1565

merged 3 commits into from
Jan 12, 2024

Conversation

ridwanmsharif
Copy link
Contributor

Description

This change adds the VM instance name to the namespace labels so aggregation by namespace is more human readable.

Related issue

b/281883632

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/namespace branch 6 times, most recently from 95a125c to b5825c2 Compare January 11, 2024 03:45
@ridwanmsharif
prometheus: add instance name to namespace label
30e880f 
This change adds the VM instance name to the `namespace` label so
aggregation by namespace is more human readable.

Signed-off-by: Ridwan Sharif <[email protected]>
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/namespace branch from b5825c2 to 30e880f Compare January 11, 2024 14:04
@ridwanmsharif
Copy link
Contributor Author

Failures unrelated. Merging now.

@ridwanmsharif ridwanmsharif merged commit 7a9f247 into master Jan 12, 2024
72 checks passed
@ridwanmsharif ridwanmsharif deleted the ridwanmsharif/namespace branch July 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferbrecht jefferbrecht jefferbrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ridwanmsharif @jefferbrecht