Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: SLES - GCloud SDK update needs sudo #1500

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

LujieDuan
Copy link
Contributor

@LujieDuan LujieDuan commented Nov 7, 2023

Description

For SLES 12 and 15, we download a versioned (453.0.0) tarball, and try to upgrade to the latest version to keep in sync with other platforms.
There is a new version of the SDK available today (454.0.0) and when call gcloud components update, the command failed because it requires sudo to actually apply the update.

Related issue

b/308605793

How has this been tested?

Integration tests to pass on SLES 12 and 15.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@LujieDuan LujieDuan marked this pull request as ready for review November 7, 2023 19:14
@LujieDuan LujieDuan requested a review from avilevy18 November 7, 2023 19:15
Copy link
Contributor

@avilevy18 avilevy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LujieDuan LujieDuan merged commit b8f3943 into master Nov 7, 2023
10 checks passed
@ridwanmsharif ridwanmsharif deleted the lujieduan-fix-sles-sdk-update branch July 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants