Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create transformation tests #1480

Merged
merged 27 commits into from
Nov 1, 2023
Merged

Create transformation tests #1480

merged 27 commits into from
Nov 1, 2023

Conversation

avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Oct 25, 2023 •
edited
Loading

Description

Create a new type of test (transformation tests) that allow developers to test ops agent processors locally.

Related issue

b/282780041

How has this been tested?

New tests pass.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 25, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 25, 2023
quentinmit
quentinmit reviewed Oct 26, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
kokoro/scripts/build/build_package.sh Outdated Show resolved Hide resolved
transformation_test/transformation_test.go Outdated Show resolved Hide resolved
quentinmit
quentinmit reviewed Oct 30, 2023
View reviewed changes
transformation_test/testdata/modify_fields/config.yaml Outdated Show resolved Hide resolved
transformation_test/transformation_test.go Outdated Show resolved Hide resolved
transformation_test/transformation_test.go Outdated Show resolved Hide resolved
transformation_test/transformation_test.go Outdated Show resolved Hide resolved
jefferbrecht
jefferbrecht reviewed Oct 30, 2023
View reviewed changes
dockerfiles/template
COPY VERSION build.sh ./
COPY debian debian
COPY pkg pkg
COPY . /work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we breaking any docker image caching assumptions with this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final build step will now be re-done if anything in the repo changes. But that probably would have caused one of the previous steps to also be different, so I think this build step would have already had different inputs in every case.

@avilevy18 avilevy18 marked this pull request as ready for review October 31, 2023 18:15
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 31, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 31, 2023
quentinmit
quentinmit approved these changes Nov 1, 2023
View reviewed changes
dockerfiles/template
COPY VERSION build.sh ./
COPY debian debian
COPY pkg pkg
COPY . /work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final build step will now be re-done if anything in the repo changes. But that probably would have caused one of the previous steps to also be different, so I think this build step would have already had different inputs in every case.

@avilevy18 avilevy18 merged commit c4a8ace into master Nov 1, 2023
7 checks passed
@avilevy18 avilevy18 deleted the avilevy-shift-left branch November 1, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferbrecht jefferbrecht jefferbrecht left review comments

@quentinmit quentinmit quentinmit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avilevy18 @quentinmit @jefferbrecht @stackdriver-instrumentation-release