Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example setup instructions for getting GCP credentials #247

Merged
merged 2 commits into from
May 16, 2023
Merged

Update example setup instructions for getting GCP credentials #247

merged 2 commits into from
May 16, 2023

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented May 16, 2023 •
edited
Loading

staged at https://google-cloud-opentelemetry--247.org.readthedocs.build/en/247/

  • Reword instructions for getting Application Default Credentials
  • Removed instructions to enable Trace/Monitoring APIs since they are enabled by default
  • Fixed list RST markup through all documents to remove ugly indentation

@aabmass aabmass marked this pull request as ready for review May 16, 2023 04:01
@aabmass aabmass requested a review from a team as a code owner May 16, 2023 04:01
@aabmass aabmass changed the title Update example setup instructions for ADC Update example setup instructions for getting GCP credentials May 16, 2023
@aabmass aabmass requested a review from punya May 16, 2023 15:49
@aabmass
Copy link
Collaborator Author

aabmass commented May 16, 2023

@punya this is a follow up to your previous review comment

@aabmass aabmass requested a review from punya May 16, 2023 16:05
@aabmass aabmass enabled auto-merge (squash) May 16, 2023 16:49
@aabmass aabmass merged commit 6713d90 into GoogleCloudPlatform:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punya punya punya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabmass @punya