-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of deprecated class BoundedDict with BoundedAttributes #238
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
56d2389
to
f803ccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you for your contribution!
/gcbrun |
I'm fixing the CI in #239 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops forgot one thing–@shevisj would you mind adding a changelog entry for this?
/gcbrun |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for contributing!
Hmm, unfortunately it looks like the BoundedAttributes class has tighter constraints on allowed attribute value types as compared with BoundedDict. I will work on getting my local dev env configured so that I can play around with it and can get tests to pass locally. |
Head branch was pushed to by a user without write access
859b3ba
to
4a18808
Compare
…m version requirement for opentelemetry-api to 1.4 for opentelemetry-exporter-gcp-trace
/gcbrun |
@shevisj do you have any idea how to fix the issue or could update this PR? |
Replace deprecated BoundedDict with BoundedAttributes and bump minimum version requirement of
opentelemetry-api
from 1.0 to 1.4 inopentelemetry-exporter-gcp-trace
Fixes #226