Refactor resource mapping logic into resource detection package #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
resource-mapping-refactor
branch
2 times, most recently
from
dd1dd1e to
36155a9
Compare
and update the exporters to use the shared code.
aabmass
force-pushed
the
resource-mapping-refactor
branch
from
36155a9 to
04d0db6
Compare
aabmass
commented
Feb 22, 2023
Comment on lines
+445
to
448
| if monitored_resource and monitored_resource.type not in ( | ||
| _resource_constants.GENERIC_NODE, | ||
| _resource_constants.GENERIC_TASK, | ||
| ): |
There was a problem hiding this comment.
Reason for this is: it doesn't seem like good UX to ever send the g.co/r/generic* since that is populated from service resource labels.
jsuereth
approved these changes
Feb 23, 2023
|
@dashpole lmk if you have any objections or I'll merge |
dashpole
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update the exporters to use the shared code.
This means the trace and metric exporter now have a dependency on the resource detector package.