Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Readonly Propagator to match the golang "One Way" propagator. #196

Merged
merged 6 commits into from
Nov 2, 2022

Conversation

muncus
Copy link
Contributor

@muncus muncus commented Sep 2, 2022

Also adds usage information to README.rst for both propagators.

Also adds usage information to README.rst for both propagators.
@dashpole
Copy link
Contributor

/gcbrun

@dashpole dashpole requested a review from aabmass September 12, 2022 20:55
@muncus muncus marked this pull request as ready for review October 4, 2022 17:16
@muncus
Copy link
Contributor Author

muncus commented Oct 4, 2022

can I get a /gcbrun?
also, would you prefer this be named "one way" propagator to keep consistency? I thought Readonly was more descriptive but i also value consistency 😄

@dashpole
Copy link
Contributor

dashpole commented Oct 4, 2022

/gcbrun

also corrects a type error with an empty set.
@muncus
Copy link
Contributor Author

muncus commented Oct 11, 2022

I've renamed it to OneWay for consistency with go and java propagators, and fixed the type issue.
I believe this is ready for review (after /gcbrun).

@dashpole
Copy link
Contributor

/gcbrun

@muncus
Copy link
Contributor Author

muncus commented Oct 21, 2022

ping.

opentelemetry-propagator-gcp/README.rst Outdated Show resolved Hide resolved
@aabmass aabmass self-assigned this Nov 2, 2022
Co-authored-by: Aaron Abbott <[email protected]>
@aabmass
Copy link
Collaborator

aabmass commented Nov 2, 2022

/gcbrun

@aabmass aabmass enabled auto-merge (squash) November 2, 2022 17:45
@aabmass aabmass merged commit 3c6f56b into GoogleCloudPlatform:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants